[jira] [Created] (FLINK-6887) Split up CodeGenerator into several specific CodeGenerator

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Created] (FLINK-6887) Split up CodeGenerator into several specific CodeGenerator

JIRA jira@apache.org
Jark Wu created FLINK-6887:
------------------------------

             Summary: Split up CodeGenerator into several specific CodeGenerator
                 Key: FLINK-6887
                 URL: https://issues.apache.org/jira/browse/FLINK-6887
             Project: Flink
          Issue Type: Bug
          Components: Table API & SQL
            Reporter: Jark Wu
             Fix For: 1.4.0


Currently, the {{CodeGenerator}} is very huge and a bit difficult to maintain. I suggest to split it up into several specific {{XXXCodeGenerator}}.

For example, create {{AggregationFunctionCodeGenerator}}  class and make it extend to {{CodeGenerator}} and move the {{def generateAggregations(...)}} method to it. The same as {{TableFunctionCollectorCodeGenerator}} and {{InputFormatCodeGenerator}}.

What do you think? [~fhueske], [~twalthr], [~sunjincheng121]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)